Accounting oracle: remove an erroneous and excess check #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
the requirement for the number of exited validators to not decrease is already checked in the staking router, and it's compared per module which is a more strict check
skozin
force-pushed
the
fix/oracle-exited-validators-check
branch
from
58aa459
to
f523e46
Compare
skozin
commented
Mar 20, 2023
Psirex
reviewed
Mar 20, 2023
|
Please consider fixing the conflicts with the target branch 🙏 UPD. resolved |
…d-validators-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirement for the number of exited validators to not decrease is already checked in the staking router, and it's compared per module which is a more strict check.
TODO:
StakingRouter.updateExitedValidatorsCountByStakingModule