Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC4906 implementation for withdrawal nft #733

Merged
merged 9 commits into from
Apr 12, 2023
Merged

ERC4906 implementation for withdrawal nft #733

merged 9 commits into from
Apr 12, 2023

Conversation

folkyatina
Copy link
Member

@folkyatina folkyatina commented Apr 10, 2023 •
edited
Loading

  • ERC4905 BatchUpdateMetadata on finalize
  • token uri now contains all the state
  • basic tests for tokenURI
  • gas test for tokenURI

@TheDZhon TheDZhon changed the base branch from feature/shapella-upgrade to fix/shapella-upgrade-from-rc1-to-rc2 April 10, 2023 08:51
@TheDZhon TheDZhon mentioned this pull request Apr 10, 2023
Merged
16 tasks
TheDZhon
TheDZhon reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Please consider using both amounts together (not exclusively).
Also, have merge conflicts with tests.

contracts/0.8.9/WithdrawalQueueERC721.sol Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueueBase.sol Show resolved Hide resolved
contracts/0.8.9/interfaces/IERC4906.sol Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueueERC721.sol Show resolved Hide resolved
Jeday
Jeday approved these changes Apr 11, 2023
View reviewed changes
contracts/0.8.9/WithdrawalQueueERC721.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will merge with the gas tests included

@TheDZhon TheDZhon merged commit da1a3d7 into fix/shapella-upgrade-from-rc1-to-rc2 Apr 12, 2023
@TheDZhon TheDZhon deleted the feature/erc4906 branch April 12, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loga4 loga4 loga4 left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

@Jeday Jeday Jeday approved these changes

@DiRaiks DiRaiks Awaiting requested review from DiRaiks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@folkyatina @TheDZhon @loga4 @Jeday