Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: churn limit explanations #748

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Doc: churn limit explanations #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ interface IWithdrawalQueue {
/// @notice The set of restrictions used in the sanity checks of the oracle report
/// @dev struct is loaded from the storage and stored in memory during the tx running
struct LimitsList {
/// @notice The max possible number of validators that might appear or exit on the Consensus
/// Layer during one day
/// @notice The max possible number of validators that might been reported as `appeared` or `exited`
/// during a single day
/// NB: `appeared` means `pending` (maybe not `activated` yet), see further explanations
// in docs for the `setChurnValidatorsPerDayLimit` func below.
/// @dev Must fit into uint16 (<= 65_535)
uint256 churnValidatorsPerDayLimit;

Expand Down Expand Up @@ -217,6 +219,15 @@ contract OracleReportSanityChecker is AccessControlEnumerable {
}

/// @notice Sets the new value for the churnValidatorsPerDayLimit
/// The limit is applicable for `appeared` and `exited` validators
///
/// NB: AccountingOracle reports validators as `appeared` once them become `pending`
/// (might be not `activated` yet). Thus, this limit should be high enough for such cases
/// because Consensus Layer has no intrinsic churn limit for the amount of `pending` validators
/// (only for `activated` instead). For Lido it's limited by the max daily deposits via DepositSecurityModule
///
/// In contrast, `exited` are reported according to the Consensus Layer churn limit.
///
/// @param _churnValidatorsPerDayLimit new churnValidatorsPerDayLimit value
function setChurnValidatorsPerDayLimit(uint256 _churnValidatorsPerDayLimit)
external
Expand Down Expand Up @@ -426,7 +437,7 @@ contract OracleReportSanityChecker is AccessControlEnumerable {

// 6. Appeared validators increase
if (_postCLValidators > _preCLValidators) {
_checkValidatorsChurnLimit(limitsList, (_postCLValidators - _preCLValidators), _timeElapsed);
_checkAppearedValidatorsChurnLimit(limitsList, (_postCLValidators - _preCLValidators), _timeElapsed);
}
}

Expand Down Expand Up @@ -589,7 +600,7 @@ contract OracleReportSanityChecker is AccessControlEnumerable {
}
}

function _checkValidatorsChurnLimit(
function _checkAppearedValidatorsChurnLimit(
LimitsList memory _limitsList,
uint256 _appearedValidators,
uint256 _timeElapsed
Expand Down