Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 upgrade cleanup #771

Merged
merged 9 commits into from
May 25, 2023
Merged

V2 upgrade cleanup #771

merged 9 commits into from
May 25, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented May 17, 2023

No description provided.

@arwer13 arwer13 requested a review from TheDZhon May 17, 2023 12:32
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates, since they are pretty essential since the Lido V2 released 👍

Did a first pass of review 👀

README.md Show resolved Hide resolved
SCRATCH_DEPLOY.md Outdated Show resolved Hide resolved
deployed-goerli.json Outdated Show resolved Hide resolved
deployed-mainnet.json Outdated Show resolved Hide resolved
deployed-mainnet.json Outdated Show resolved Hide resolved
docs/dev-fork.md Show resolved Hide resolved
docs/node-operator-manual.md Outdated Show resolved Hide resolved
docs/oracle-operator-manual.md Outdated Show resolved Hide resolved
docs/protocol-levers.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the suggested changed and deployment tx resolution discussed with @bulbozaur 👍

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/protocol-levers.md Outdated Show resolved Hide resolved
@arwer13 arwer13 merged commit 0c645a8 into develop May 25, 2023
@arwer13 arwer13 deleted the v2-upgrade-cleanup branch May 25, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants