New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic safety issue: guard against double drop #48

Merged

liebharc merged 1 commit into liebharc:master from JOE1994:panic_safety_fix

Jan 11, 2021

Contributor

JOE1994 commented Jan 11, 2021

Fixes #47

Wraps self with ManuallyDrop to guard against double drop bugs.
ManuallyDrop is a zero-cost wrapper type.

Thank you for reviewing this PR 👍


          fix panic safety issue: guard against double drop

f1320f0

Owner

liebharc commented Jan 11, 2021

Wow, thanks a lot for reporting AND fixing this. Much appreciated :).

liebharc merged commit bacf18e into liebharc:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet