Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Current senna version function #237

Closed
wants to merge 6 commits into from
Closed

Conversation

diegonvs
Copy link
Contributor

No description provided.

@diegonvs diegonvs changed the title JSDoc Current senna version function Dec 12, 2017
@diegonvs
Copy link
Contributor Author

diegonvs commented Dec 12, 2017

#232 @brunobasto

@brunobasto
Copy link

Just started reviewing :)

:octocat: Sent from GH.

@jbalsas
Copy link
Contributor

jbalsas commented Dec 13, 2017

I think this has been merged and released as 2.5.0! 🎉

@jbalsas jbalsas closed this Dec 13, 2017
@caneta
Copy link

caneta commented Oct 5, 2018

How to get this info in Liferay 7.1 CE? Liferay.SPA.version or Liferay.SPA.app.version do not exist...
Maybe Liferay 7.1 has a Senna version < 2.5.0?

@jbalsas
Copy link
Contributor

jbalsas commented Oct 5, 2018

Hey @caneta, Liferay 7.1 uses senna 2.6.2. I was looking into this, and we only added version info here, but we don't expose it. I've created https://issues.liferay.com/browse/LPS-86070 to make sure we finish this properly.

I tried myself, and I got the following:

Liferay.SPA.version
08:25:14.833 "<%= version %>"

@diegonvs, I think the build process isn't working as expected? Could you take a look and send a followup PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants