Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) removed deprecated syntax for lifetime in traits #40

Closed
wants to merge 1 commit into from
Closed

(fix) removed deprecated syntax for lifetime in traits #40

wants to merge 1 commit into from

Conversation

brycefisher
Copy link

I don't really understand whats going on, but removing 'static
lifetime allows this library to compile and tests to pass. However
104 tests were ignored.

This fixes the error:
src/encoding/types.rs:105:25: 105:32 error: expected ident, found 'static
src/encoding/types.rs:105 pub trait StringWriter: 'static {

I don't really understand whats going on, but removing 'static
lifetime allows this library to compile and tests to pass. However
104 tests were ignored.

This fixes the error:
src/encoding/types.rs:105:25: 105:32 error: expected ident, found `'static`
src/encoding/types.rs:105 pub trait StringWriter: 'static {
@SimonSapin
Copy link
Collaborator

You may need to update your compiler, this was added in #39 due to a very recent language change.

Current master builds fine for me with Rust nightly 2e92c67dc 2014-08-28. Unfortunately, you might be getting outdated nightly because of cache invalidation problems wit the CDN: rust-lang/rust#16649

@SimonSapin
Copy link
Collaborator

Or did it get deprecated again in the last few hours?

@brycefisher
Copy link
Author

Thanks @SimonSapin! I wondered if I was missing something. I'll update my compiler locally and try to verify... given the uncertainty, maybe this shouldn't be merged in.

@lifthrasiir
Copy link
Owner

While this issue is invalid, I'd like to keep this open for a while until the cached nightly gets updated.

@brycefisher
Copy link
Author

Sounds like a plan -- thanks for being so responsive!

@lifthrasiir
Copy link
Owner

Okay, the nightly has been updated and this PR is not necessary now. Thank you for the PR anyway!

@brycefisher brycefisher deleted the fix/types-lifetime-error branch August 30, 2014 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants