Too wide matchName for InheritedNewAbstractMethodProblem

[patriknw]

If one mixin ActorLogging (trait) it correctly complains about InheritedNewAbstractMethodProblem, but the filter to exclude it is:

ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("akka.actor.ActorLogging.akka$actor$ActorLogging$$_log_=")
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("akka.actor.ActorLogging.log")
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("akka.actor.ActorLogging.akka$actor$ActorLogging$$_log")

Looks like matchName is for the trait that introduces the problem, instead of the target trait. That means that after adding such filter other breakages of mixing in ActorLogging will not be detected.

[dwijnand]

/cc @2m?

[2m]

For now I have created a failing test-case: #197 Anyone else is free to jump on it if interested.

More information on the issue is in akka/akka#23563 (comment) by @nick-nachos

It is the sbt plugin that needs a fix, as the reporter itself has correct report on this issue:

abstract method foo()Int in interface AA is inherited by class A in new version.

[nick-nachos]

@2m I am not sure what you mean by:

It is the sbt plugin that needs a fix

I have fixed the issue locally by changing this:

case class InheritedNewAbstractMethodProblem(clazz: ClassInfo, inheritedMethod: MemberInfo) extends AbstractMethodProblem(inheritedMethod)

to this:

case class InheritedNewAbstractMethodProblem(clazz: ClassInfo, inheritedMethod: MemberInfo) extends AbstractMethodProblem(new MemberInfo(clazz, inheritedMethod.bytecodeName, inheritedMethod.flags, inheritedMethod.sig))

This fix is in par with the analysis I made in the related akka issue. Would you like to make the change yourself, or should I proceed with a pull request?

[2m]

Fix sounds good. Yes, please proceed with a pull request!

[nick-nachos]

Ok great. Before proceeding with this I should note that this change will have a breaking effect to any current consumers of Filters based on the InheritedNewAbstractMethodProblem, which will have to rewrite the corresponding filter expressions. Given that current behavior is considered a bug, I assume that this is not a problem, but I would like your confirmation as well.

To demonstrate with an example, in the scripted test case you provided a current consumer would have to write a filter expression of the form:

ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("T.bar")

which will have to be changed to:

ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("A.bar")