Handle POM-only modules by creating empty Definitions #743
Conversation
|
Hi @rossabaker, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
|
|
Optimistically merging 🤷 Thank you! |
|
Would having this in a release save you any time/trouble? We haven't released here in 6 months, but I looked and this PR is the only PR merged in that time that isn't just a Steward version bump. |
|
It certainly would, a number of builds have applied a workaround for this including otel4s, typelevel-scalafix, and typelevel/toolkit off the top of my head. |
|
okay, I've made #749 and assigned myself; I should be able to find the time to take care of it within the next few weeks |
### What changes were proposed in this pull request? The pr aims to upgrade mima-core from 1.1.0 to 1.1.2. ### Why are the changes needed? - New version includes bug fixed, eg: 1.Handle POM-only modules by creating empty Definitions by rossabaker in lightbend-labs/mima#743 - Release note: 1.https://github.com/lightbend/mima/releases/tag/1.1.2 2.https://github.com/lightbend/mima/releases/tag/1.1.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #41294 from panbingkun/SPARK-43771. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
### What changes were proposed in this pull request? The pr aims to upgrade mima-core from 1.1.0 to 1.1.2. ### Why are the changes needed? - New version includes bug fixed, eg: 1.Handle POM-only modules by creating empty Definitions by rossabaker in lightbend-labs/mima#743 - Release note: 1.https://github.com/lightbend/mima/releases/tag/1.1.2 2.https://github.com/lightbend/mima/releases/tag/1.1.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#41294 from panbingkun/SPARK-43771. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
References #702.
I don't know much about MiMa's internals. This may be nonsense, but it fixes typelevel/otel4s#122.