Implement the Any2StringAdd rewrite #10
Conversation
dwijnand
changed the title
|
|
||
| private def addToString(term: Term) = term match { | ||
| case _: Term.Name | _: Term.Select | _: Term.Block => Patch.addRight(term, ".toString") | ||
| case _ => Patch.addLeft(term, "(") + Patch.addRight(term, ").toString") |
There was a problem hiding this comment.
my only concern here is that it unnecessarily boxes primitives.
There was a problem hiding this comment.
Ah, that must be why the deprecation message for these is to use string interpolation.
Should we do "" + x for these? (And "" + (...) for non-Name/Select/Block.) . Or should we try to rewrite it to use string interpolation?
There was a problem hiding this comment.
I don't know. IIRC, string interpolation is special-cased by the compiler in 2.13, so it's probably at least as efficient as other options, if not more so?
There was a problem hiding this comment.
Yeah it's the right choice. But for mechanical rewrites you could get some weird rewrites, so maybe this is best?
There was a problem hiding this comment.
that must be why the deprecation message for these is to use string interpolation.
IIRC, string interpolation is special-cased by the compiler in 2.13
Yes. see scala/scala#7201 scala/bug#11025
Part of scala/scala-dev#327