Updated list of supported element props. (#6)

* Updated list of supported element props. * version bumped to 0.3.1 --------- Co-authored-by: Uğur Aslan <[email protected]>
lightning-js · Oct 4, 2023 · 8821ac8 · 8821ac8
1 parent a6b4a08
commit 8821ac8
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 29 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "blits-vscode",
   "displayName": "blits-vscode",
   "description": "Visual Studio Code extension for Blits",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "engines": {
     "vscode": "^1.81.0"
   },

diff --git a/src/completionItems/componentProps.js b/src/completionItems/componentProps.js
@@ -20,7 +20,7 @@ const path = require('path')
 const fs = require('fs-extra')
 const parse = require('../parsers')
 const templateHelper = require('../helpers/template')
-const coreProps = require('./coreProps')
+const elementProps = require('./elementProps')
 
 module.exports = async (tag, attributes, doc, docAst) => {
   let completionItems = []
@@ -80,8 +80,8 @@ module.exports = async (tag, attributes, doc, docAst) => {
   }
 
   // always merge with core props
-  const coreCompletionItems = await coreProps(attributes)
-  completionItems = completionItems.concat(coreCompletionItems)
+  const elementCompletionItems = await elementProps(attributes)
+  completionItems = completionItems.concat(elementCompletionItems)
 
   return completionItems
 }
diff --git a/src/completionItems/coreProps.js → src/completionItems/elementProps.js b/src/completionItems/coreProps.js → src/completionItems/elementProps.js
@@ -18,41 +18,30 @@
 const vscode = require('vscode')
 
 // temporary solution
-const coreNodeProps = [
+const elementProps = [
   'x',
   'y',
+  'w',
   'width',
+  'h',
   'height',
+  'z',
+  'zIndex',
   'alpha',
   'color',
-  'colorTop',
-  'colorBottom',
-  'colorLeft',
-  'colorRight',
-  'colorTl',
-  'colorTr',
-  'colorBl',
-  'colorBr',
   'parent',
-  'zIndex',
-  'texture',
-  'textureOptions',
-  'shader',
-  'shaderProps',
-  'zIndexLocked',
   'scale',
+  'rotation',
   'mount',
-  'mountX',
-  'mountY',
   'pivot',
-  'pivotX',
-  'pivotY',
-  'rotation',
+  'src',
+  'ref',
+  'effects'
 ]
 
 module.exports = async (attributes) => {
   let completionItems = []
-  coreNodeProps.forEach((prop) => {
+  elementProps.forEach((prop) => {
     if (!attributes.includes(prop)) {
       const completionItem = new vscode.CompletionItem(
         prop,

diff --git a/src/completionItems/index.js b/src/completionItems/index.js
@@ -17,5 +17,5 @@
 
 module.exports = {
   componentProps: require('./componentProps'),
-  coreProps: require('./coreProps'),
+  elementProps: require('./elementProps'),
 }
diff --git a/src/completionProviders/templateAttributes.js b/src/completionProviders/templateAttributes.js
@@ -41,7 +41,7 @@ module.exports = vscode.languages.registerCompletionItemProvider(
         if (tagName) {
           // hardcoded for now, Blits will provide a map for rendererer props
           if (tagName === 'Element') {
-            return await completionItems.coreProps(
+            return await completionItems.elementProps(
               tagName,
               attributes,
               document,