fix: Inspector get properties from prototype (#439)

lightning-js · Nov 7, 2024 · 1cccaa9 · 1cccaa9
2 parents 25f8b17 + 470198c
commit 1cccaa9
Showing 1 changed file with 23 additions and 15 deletions.
diff --git a/src/main-api/Inspector.ts b/src/main-api/Inspector.ts
@@ -272,25 +272,33 @@ export class Inspector {
   ): CoreNode | CoreTextNode {
     // Define traps for each property in knownProperties
     knownProperties.forEach((property) => {
-      const originalProp = Object.getOwnPropertyDescriptor(node, property);
-      if (!originalProp) {
+      let originalProp = Object.getOwnPropertyDescriptor(node, property);
+
+      if (originalProp === undefined) {
+        // Search the prototype chain for the property descriptor
+        const proto = Object.getPrototypeOf(node) as CoreNode | CoreTextNode;
+        originalProp = Object.getOwnPropertyDescriptor(proto, property);
+      }
+
+      if (originalProp === undefined) {
         return;
       }
 
-      Object.defineProperties(node, {
-        [property]: {
-          get() {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-return
-            return originalProp.get?.call(node);
-          },
-          set(value) {
-            originalProp.set?.call(node, value);
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
-            this.updateNodeProperty(div, property, value);
-          },
-          configurable: true,
-          enumerable: true,
+      Object.defineProperty(node, property, {
+        get() {
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+          return originalProp?.get?.call(node);
+        },
+        set: (value) => {
+          originalProp?.set?.call(node, value);
+          this.updateNodeProperty(
+            div,
+            property as keyof CoreNodeProps | keyof CoreTextNodeProps,
+            value,
+          );
         },
+        configurable: true,
+        enumerable: true,
       });
     });