Remove support for (old-style) non-module visualizations and clean up dependencies #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Update README.md travis.yml
mathisonian
changed the title
|
Last commits fix the build for |
|
This is huge! Especially being able to specify paths directly to visualizations, and the |
mathisonian
added a commit
that referenced
this pull request
Dec 6, 2015
Remove support for (old-style) non-module visualizations and clean up dependencies
|
Yes, we now only need to worry about compiling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly simplifies the logic involved in importing custom visualization by enforcing the rule that every custom viz must take the form of an node module, whether it be local or on npm/github (instead of the old style where visualizations could just conform to a standard folder structure).
Besides simplifying the code, this has the following benefits:
npm link .to link and develop visualizations locally. Users now can simply enter the folder pathnode-sass, which should make it easier to support newer versions of node (see, npm install fails on node v4.0.0 #54, /cc @sethvincent), and hopefully will help make electron builds more straightforward.The removal of this feature has been planned and previously discussed (see #31 and in gitter).
Slightly tangential but this pull request also removes build (gulp) dependencies from
dependenciestodevDependencies. They were previously listed directly independenciesdue to an issue with heroku builds, but recent updates to the heroku buildpack make this unnecessary./cc @freeman-lab