Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: only 2 bytes for open_channel.max-num-htlcs #4

Closed
wants to merge 1 commit into from

Conversation

pm47
Copy link
Collaborator

@pm47 pm47 commented Nov 15, 2016

do we really want to have more than 65 536 oustanding htlcs?

@cdecker
Copy link
Collaborator

cdecker commented Nov 15, 2016

I think the argument was that we want to have all the num-XXX fields to be 4 bytes, we even have some limit on outstanding HTLCs (300 IIRC), but this is for uniformity's sake :-)

@rustyrussell
Copy link
Collaborator

Christian Decker [email protected] writes:

I think the argument was that we want to have all the num-XXX fields to be 4 bytes, we even have some limit on outstanding HTLCs (300 IIRC), but this is for uniformity's sake :-)

Yes.bytes. Let me start a new spec on how to extend the protocol which
should explain this and much else that's assumed...

Thanks!
Rusty.

@pm47
Copy link
Collaborator Author

pm47 commented Nov 16, 2016

Great! closing this one

@pm47 pm47 closed this Nov 16, 2016
@pm47 pm47 deleted the patch-1 branch November 16, 2016 11:23
fjahr pushed a commit to fjahr/lightning-mw that referenced this pull request Dec 24, 2018
@TheBlueMatt TheBlueMatt mentioned this pull request Nov 4, 2019
ifuensan added a commit to ifuensan/bolts that referenced this pull request Apr 23, 2023
ifuensan added a commit to ifuensan/bolts that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants