Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*Require* payment_secret for multi-part payments #712

Merged
merged 1 commit into from
Dec 16, 2019
Merged

*Require* payment_secret for multi-part payments #712

merged 1 commit into from
Dec 16, 2019

Commits on Dec 13, 2019

  1. BOLT 4/11: require payment_secret for multi-part payments. 

    This means the BOLT11 invoice must offer it (we already say it must
set the field if it offers it), and that the receiving node must
require it (again, we already say it must check it if it requires it).

Without the payment_secret, MPP payments are especially vulnerable to
probing attacks: unlike normal payments (with amounts) they can be
detected with 1msat payment probes.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    6ad8ee4 View commit details
    Browse the repository at this point in the history