Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose description from Invoice's offer/refund #2206

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lightning/src/offers/invoice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ use crate::offers::refund::{IV_BYTES as REFUND_IV_BYTES, Refund, RefundContents}
use crate::offers::signer;
use crate::onion_message::BlindedPath;
use crate::util::ser::{HighZeroBytesDroppedBigSize, Iterable, SeekReadable, WithoutLength, Writeable, Writer};
use crate::util::string::PrintableString;

use crate::prelude::*;

Expand Down Expand Up @@ -452,6 +453,12 @@ struct InvoiceFields {
}

impl Invoice {
/// A complete description of the purpose of the originating offer or refund. Intended to be
/// displayed to the user but with the caveat that it has not been verified in any way.
pub fn description(&self) -> PrintableString {
self.contents.description()
}

/// Paths to the recipient originating from publicly reachable nodes, including information
/// needed for routing payments across them.
///
Expand Down Expand Up @@ -607,6 +614,15 @@ impl InvoiceContents {
}
}

fn description(&self) -> PrintableString {
match self {
InvoiceContents::ForOffer { invoice_request, .. } => {
invoice_request.inner.offer.description()
},
InvoiceContents::ForRefund { refund, .. } => refund.description(),
}
}

fn fields(&self) -> &InvoiceFields {
match self {
InvoiceContents::ForOffer { fields, .. } => fields,
Expand Down Expand Up @@ -939,6 +955,7 @@ mod tests {
use crate::offers::test_utils::*;
use crate::onion_message::{BlindedHop, BlindedPath};
use crate::util::ser::{BigSize, Iterable, Writeable};
use crate::util::string::PrintableString;

trait ToBytes {
fn to_bytes(&self) -> Vec<u8>;
Expand Down Expand Up @@ -975,6 +992,7 @@ mod tests {
invoice.write(&mut buffer).unwrap();

assert_eq!(invoice.bytes, buffer.as_slice());
assert_eq!(invoice.description(), PrintableString("foo"));
assert_eq!(invoice.payment_paths(), payment_paths.as_slice());
assert_eq!(invoice.created_at(), now);
assert_eq!(invoice.relative_expiry(), DEFAULT_RELATIVE_EXPIRY);
Expand Down Expand Up @@ -1057,6 +1075,7 @@ mod tests {
invoice.write(&mut buffer).unwrap();

assert_eq!(invoice.bytes, buffer.as_slice());
assert_eq!(invoice.description(), PrintableString("foo"));
assert_eq!(invoice.payment_paths(), payment_paths.as_slice());
assert_eq!(invoice.created_at(), now);
assert_eq!(invoice.relative_expiry(), DEFAULT_RELATIVE_EXPIRY);
Expand Down
6 changes: 5 additions & 1 deletion lightning/src/offers/offer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ impl Offer {
/// A complete description of the purpose of the payment. Intended to be displayed to the user
/// but with the caveat that it has not been verified in any way.
pub fn description(&self) -> PrintableString {
PrintableString(&self.contents.description)
self.contents.description()
}

/// Features pertaining to the offer.
Expand Down Expand Up @@ -536,6 +536,10 @@ impl OfferContents {
self.metadata.as_ref().and_then(|metadata| metadata.as_bytes())
}

pub fn description(&self) -> PrintableString {
PrintableString(&self.description)
}

#[cfg(feature = "std")]
pub(super) fn is_expired(&self) -> bool {
match self.absolute_expiry {
Expand Down
6 changes: 5 additions & 1 deletion lightning/src/offers/refund.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ impl Refund {
/// A complete description of the purpose of the refund. Intended to be displayed to the user
/// but with the caveat that it has not been verified in any way.
pub fn description(&self) -> PrintableString {
PrintableString(&self.contents.description)
self.contents.description()
}

/// Duration since the Unix epoch when an invoice should no longer be sent.
Expand Down Expand Up @@ -489,6 +489,10 @@ impl AsRef<[u8]> for Refund {
}

impl RefundContents {
pub fn description(&self) -> PrintableString {
PrintableString(&self.description)
}

#[cfg(feature = "std")]
pub(super) fn is_expired(&self) -> bool {
match self.absolute_expiry {
Expand Down