Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose withheld amount for underpaying HTLCs in PaymentForwarded #2858

Merged

Commits on Jan 31, 2024

  1. Struct-ify claim_along_route args.

    Lays groundwork to make claim_payment* test utils easier to adapt without
    changing a million callsites.
    valentinewallace authored and tnull committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    42490ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2616f02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e47266 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Expose skimmed_fee_msat in PaymentForwarded

    We generally allow routing nodes to forward less than the expected HTLC
    amount, if the receiver knowingly accepts this and claims the
    underpaying HTLC (see `ChannelConfig::accept_underpaying_htlcs`). This
    use case is in particular useful for the LSPS2/JIT channel setting where
    the intial underpaying HTLC pays for the channel open.
    
    While we previously exposed the withheld amount as
    `PaymentClaimable::counterparty_skimmed_fee_msat` on the receiver side,
    we did not individually provide it on the forwarding node's side.
    Here, we therefore expose this additionally withheld amount via
    `PaymentForwarded::skimmed_fee_msat`.
    tnull committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9644588 View commit details
    Browse the repository at this point in the history