-
Notifications
You must be signed in to change notification settings - Fork 366
Meeting Notes 2022 11 28
Elias Rohrer edited this page Nov 28, 2022
·
1 revision
- 0.0.113 (https://github.com/lightningdevkit/rust-lightning/milestone/30)
- Gonna get in everything we can up until christmas
- Labeled stuff is important. Some is must-have, some would be nice to have
- 0.1 (https://github.com/lightningdevkit/rust-lightning/milestone/1)
- Bunch of stuff tat might slip
- A lot of stuff that is pretty minor but we’ll see where it lands
- Developer support
- Only one is probably small addition to key management section in the docs that includes some guidance on how to create a unified wallet using BDK w/ bdk code example
- Encouraging users to use a hardened child key and diff derivation path to create an LDK seed that’s diff from internal and external addresses
- A lot of people have been asking for examples of this, looking for “best practices” so good to have guidance there
- Other: replit has a bounty open for $50 for bdk or ldk
- Matt: we already had 2 PRs open where people are just trying to claim the bounty with a trivial readme fix
- We should tweet that that doesn’t qualify
- One merged already oops
- We do have one legitimate first-PR open re: adding a field to a payment event
- https://twitter.com/hhua_/status/1596205654183579654
- One of our users 617878(?) has done a really good podcast about his valera labs stuff working with LDK
- Payment protocols
- Offers PRs chugging along
- Invoice request encoding needs review
- Jeff working on follow up for refunds use case
- Async payments
- Lots of discussion recently on how to make these work for offers, gonna be meeting with rusty about it
- Will be based on keysend HTLCs, no use on waiting for PTLCs since they don’t add PoP as we originally thought (at least not yet, there may be a scheme in the future)
- Working on payment retries in the background
- Offers PRs chugging along
- Language bindings
- Not much between a release
- This upcoming one is gonna be a bit difficult to adapt, but we’ll see what happens when we get that far
- Arik: bunch of issues we’re aware of in swift from user feedback, we’ll see how nasty this release ends up being. Maybe we’ll be able to include some of the fixes in there
- Taproot support
- Mostly preparatory refactors right now
- Working on removing signer persistence from keysinterface bc we want a single method that returns signers.
- Reason is to have a single method that returns a signer, otherwise as we include more signers (like a taproot sign trait, similar to existing BaseSign trait) which will mostly generate ecdsa sigs for a few of the methods there. w/ taproot, we’ll be generating schnorr sigs, so need a completely diff trait. As we add more traits, we want to avoid adding more methods to the interface. Should be close, then we can keep making progress
- Taproot itself: had nonce simplification proposal made to laolu’s branch, and i feel like that has gone stale a bit, haven’t heard back in a few days. At the start of the month, he wanted to target interop lnd<>ldk by end of november, doesn’t look like it’s happening. So we’ll see
- It’s been a bit meandering, the nonce changes we want are overall looking likely to go on. Have some naming stuff to work out with shutdown flow still.
- Anchor outputs
- There’s the PR that exposes htlc bumping event. Got a lot of review there, seems close. (1825). Comments from last week have been addressed, good for another round
- Dependent PR based on that introduces feature bits and adds an e2e test doing happy flow, consuming those events. That all works. Once that’s in, will be following up with a good bit of more tests doing edge cases, unhappy paths, etc.
- Also working on wallet interface so we can handle anchor fee bumping for users seamlessly – coming soon!
- LSP
- VSS (Wallet Storage Provider) or Versioned Storage Service
- Going back and forth for server side options that do REST instead of grpc
- LDK Lite
- Generally everything is moving since seemingly a lot of people are interested in doing tx sync via confirm interface, decided to upstream tx sync in its own crate sooner rather than later
- Elias opened a PR towards that, tho some things need to be clarified to make it mergeable
- Since it’s ripped out of LdkLite, in the process of rebasing LdkLite on this change and implementing e2e tests
- Dual funding channels (new)
- Still got that message encoding PR up. Not super confident yet but we can merge it in parts. Nothing’s changed so far on discussion for draft spec. Most discussions are around tx sig ordering, some back and forth there
- Would hold off on it for a bit but if anyone wants to review, would be great
- Quite close with getting draft up for channel states, but matt mentioned a good idea around if we can separate them into 2 channel objects for pre funding and post funding
- Matt: no pressure on applying this refactor on existing Channel, would be a substantial refactor
- May make sense to just do it for new negotiation types, and then create a channel that jumps forward in its state, then in a few years we can drop the old chan negotiation
- VLS (https://gitlab.com/lightning-signer/validating-lightning-signer)
- Devrandom: updated VLS to the latest LDK 0.0.112
- Working on updating lnrod
- In general, working towards a beta of VLS
- Only ask for LDK right now is we need the bolt12 parsing, which y’all are working on
- Matt: how much of bolt12 parsing do you need?
- Just enough to see the destination, the amount, and the expiration, and validate the sig
- Matt: so that’d be on invoices. i think we’ll get invoice requests, not invoices by end of the year
- Just need invoices in first quarter of next year
- Ken: synchronizing w/ CLN – they’re in the trailing end of a release.
- Devrandom: updated VLS to the latest LDK 0.0.112
- Sensei (https://github.com/L2-Technology/sensei)
- Synonym (https://github.com/synonymdev/ldk-node-js)
- Komodo DEX (https://github.com/KomodoPlatform/atomicDEX-API)
- Working on swaps, which is new
- Not waiting on ldk, need stuff related to min final cltv
- Duncan opened a PR for this, will be working on that soon
- Needed to make it prod ready
- 2022/11/21 (https://github.com/lightning/bolts/issues/1041)
- Matt: opened one issue the other day, we need to update the way we handle htlc PRs at some point
- Continued bolt12 discussion and dual funding and splicing
- review begs?
- Val begs for JIT channel review