Block on Proof Courier Service Connection Attempt #1203
+82
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the proof transfer ChainPorter state is re-executed once proof transfer backoff attempts have been exhausted. In the absence of this commit, the next opportunity for re-attempting proof transfer would be when tapd restarts (pending parcels are processed on startup).
Pull Request Test Coverage Report for Build 11917368837Details
💛 - Coveralls |
The change ensures that the courier service connection attempt is blocking rather than synchronous. This prevents proof transfers from failing due to attempts to use connections before they are fully established, simplifying debugging. Both the connection and transfer steps are part of the backoff procedure, so failures in either step will trigger re-attempts.
This commit adds a new default value for the proof courier service response timeout which was added in the previous commit.
Set the request timeout for the tapd harness universe courier service to an appropriate value to ensure tests pass consistently.
ffranr
force-pushed
the
block-proof-courier-connect
branch
from
e0aa341
to
c3e2b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the reliability of the proof courier service and the robustness of the proof transfer process:
These updates strengthen the courier service's reliability and make proof transfers more fault-tolerant.