multi: encode/decode keys with their parity byte #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Yeah I think just embracing the "JIT x-only" approach will simplify our lives a lot. We tried to skirt around it can consider the TLV format serialization as "going on chain" but still neded up with things being mixed a bit.
We could also do things like modify the serialization we use for key families before we hash them as well, though this smaller changes fixes some of the non-determinsitic failures we've been seeing elsewhere.
I think the only thing we need to keep in place is the schnorr adherence at the VM level, since that's essentially the same as verifying a taproot output on chain.
jharveyb
force-pushed
the
preserve-parity-byte
branch
from
2bb56a6
to
249b8a9
Compare
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff of #176.
Currently public keys are sometimes (such as in addresses) unconditionally encoded with an even parity. If that key actually has odd parity, and is already stored, then key upserts behave incorrectly, causing other issues.
To resolve this, we migrate all key encoding & decoding away from the x-only format to the compressed format. This adds a few bytes to the size of some types when encoded, but other techniques can be used to compactly repesented key parity for those types.
Requires BIP updates.