utxonursery: remove nursery [DO NOT REVIEW] #2000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To provide more diagnostic information when unit tests panic.
Previously IncubateOutputs was a sequence of independent actions. The construct to incubate all outputs of a commit tx in one single call was not used anymore. This commit splits IncubateOutput into logical functions.
This was referenced Oct 2, 2018
Merged
|
Rebase of the outgoing contest resolver started in master...joostjager:outgoing-resolver |
|
the holy grail |
|
I created a tracking issue for the holy grail: #3688. Closing now and just keeping this PR as a reference to look back at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the sweeper PR #1960. It refactors the resolvers to use the sweeper directly instead of handing off outputs to nursery. This gets rid of code duplication between resolvers and nursery, as both contained code to wait for CSV/CLTV timeouts.
Current state of the PR is that it: