Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnd_test: increase test timeouts #2224

Merged
merged 4 commits into from
Nov 28, 2018

Conversation

halseth
Copy link
Contributor

@halseth halseth commented Nov 26, 2018

Split off from #2116.

In preparation for the added propagation delay by separating the miner
and the chain backend, we increase several timeouts throughout the test,
and extract them into constants that can easily be altered.

lnd_test.go Outdated Show resolved Hide resolved
lnd_test.go Outdated Show resolved Hide resolved
lnd_test.go Outdated Show resolved Hide resolved
lnd_test.go Show resolved Hide resolved
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour P2 should be fixed if one has time needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet labels Nov 27, 2018
@halseth halseth force-pushed the itest-timeouts branch 5 times, most recently from 0af47a6 to 5c6d570 Compare November 27, 2018 08:42
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎯

Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@halseth halseth merged commit b07499f into lightningnetwork:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet P2 should be fixed if one has time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants