Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoices: create package #2355

Merged
merged 1 commit into from
Jan 8, 2019
Merged

invoices: create package #2355

merged 1 commit into from
Jan 8, 2019

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Dec 20, 2018 •
edited
Loading

Isolates the invoice registry in a separate package. It is preparation for the creation of an invoices sub server.

@joostjager joostjager mentioned this pull request Dec 20, 2018
Merged
@joostjager joostjager force-pushed the move-invoices branch 2 times, most recently from 7479ecb to 14de8c3 Compare December 20, 2018 22:45
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour database Related to the database/storage of LND payments Related to invoices/payments labels Dec 21, 2018
@joostjager joostjager force-pushed the move-invoices branch 2 times, most recently from 00e0a28 to 9696c60 Compare January 5, 2019 07:45
@Roasbeef
Copy link
Member

Roasbeef commented Jan 7, 2019

Fails travis atm with linter checks.

@joostjager
Copy link
Contributor Author

@Roasbeef fixed

@joostjager
Copy link
Contributor Author

Hmm different error now

@joostjager
Copy link
Contributor Author

Another circular dep just in the test

@joostjager
invoices: create package
c1eaf60 
This commit isolates the invoice registry in a separate package. It is
a preparation for the creation of an invoices sub server.
@joostjager
Copy link
Contributor Author

Good now, PTAL

Roasbeef
Roasbeef approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Roasbeef Roasbeef merged commit 4ac54dc into lightningnetwork:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
database Related to the database/storage of LND enhancement Improvements to existing features / behaviour payments Related to invoices/payments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joostjager @Roasbeef