config: increase default trickle delay from 30s to 1m30s #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we increase the default trickle delay from 30s to 1m30s. We do this as before we implement the new INV gossip mechanism, we want to de-emphasise the quick propagation of updates through the network which eats up bandwidth.
cfromknecht
reviewed
Jan 26, 2019
| @@ -49,7 +49,7 @@ const ( | |||
| defaultRPCHost = "localhost" | |||
| defaultMaxPendingChannels = 1 | |||
| defaultNoSeedBackup = false | |||
| defaultTrickleDelay = 30 * 1000 | |||
| defaultTrickleDelay = 90 * 1000 | |||
There was a problem hiding this comment.
that would break old configs I guess, but I agree it would be nice to make all flags use time.Duration.
There was a problem hiding this comment.
hmm, yeah that is unfortunate that it doesn't. we could migrate to a trickleinterval that uses time.Duration and deprecate trickledelay, though that can be done later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we increase the default trickle delay from 30s to 1m30s.
We do this as before we implement the new INV gossip mechanism, we want
to de-emphasise the quick propagation of updates through the network
which eats up bandwidth.