-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing: add outgoing channel restriction #2572
Merged
joostjager
merged 1 commit into
lightningnetwork:master
from
joostjager:outgoing-chan-selection
Feb 9, 2019
Merged
routing: add outgoing channel restriction #2572
joostjager
merged 1 commit into
lightningnetwork:master
from
joostjager:outgoing-chan-selection
Feb 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
outgoing-chan-selection
branch
2 times, most recently
from
February 1, 2019 14:37
c134915
to
4241820
Compare
joostjager
changed the title
routing: add outgoing channel restriction [no review]
routing: add outgoing channel restriction
Feb 1, 2019
joostjager
force-pushed
the
outgoing-chan-selection
branch
from
February 4, 2019 12:37
4241820
to
401a12f
Compare
joostjager
force-pushed
the
outgoing-chan-selection
branch
3 times, most recently
from
February 6, 2019 07:05
56313f6
to
c35513d
Compare
Roasbeef
added
enhancement
Improvements to existing features / behaviour
rpc
Related to the RPC interface
routing
payments
Related to invoices/payments
labels
Feb 7, 2019
joostjager
force-pushed
the
outgoing-chan-selection
branch
from
February 7, 2019 07:59
c35513d
to
d69d70a
Compare
cfromknecht
reviewed
Feb 8, 2019
joostjager
force-pushed
the
outgoing-chan-selection
branch
from
February 8, 2019 14:28
d69d70a
to
2898389
Compare
@cfromknecht ptal |
cfromknecht
approved these changes
Feb 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 very useful feature :)
wpaulino
reviewed
Feb 8, 2019
joostjager
force-pushed
the
outgoing-chan-selection
branch
from
February 8, 2019 22:06
2898389
to
7c30a8c
Compare
@wpaulino ptal |
wpaulino
approved these changes
Feb 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💾
This was referenced Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvements to existing features / behaviour
payments
Related to invoices/payments
routing
rpc
Related to the RPC interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to SendPayment to restrict the payment to a specific outgoing channel.
One of the use cases of this is to be able to balance channels passively. Paying a higher fee for a payment, but at the same time increasing the receive capacity of a specific channel.
This is an alternative to making a dedicated payment to yourself to achieve the same goal, which may overall be more costly in terms of routing fees.