Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnrpc+routing: remove k shortest path finding #3054

Merged
merged 1 commit into from
May 10, 2019

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented May 7, 2019

This PR is the follow up of #2497. After deprecating the num_routes parameter in lnd version 0.6, the parameter and all k-shortest related code can now be removed.

@joostjager joostjager force-pushed the remove-k-shortest branch 2 times, most recently from 5cb7d4b to b6c2364 Compare May 7, 2019 17:01
@cfromknecht cfromknecht added this to the 0.7 milestone May 8, 2019
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impossible not to like :)

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only minor thing is that the RPC is still named QueryRoutes.

@joostjager
Copy link
Contributor Author

joostjager commented May 10, 2019

LGTM - only minor thing is that the RPC is still named QueryRoutes.

I didn't think about that, but changing that would break all clients, even the ones that only request a single route already now. Not renaming it requires users that rely on multiple routes to notice this change, because their application may silently behave differently.

@Roasbeef Roasbeef merged commit f8c824f into lightningnetwork:master May 10, 2019
@C-Otto
Copy link
Contributor

C-Otto commented Jun 15, 2019

Could you add some information for those users who need more than a single route?

@joostjager
Copy link
Contributor Author

@C-Otto you should be able to implement this client side by using the ignore parameters of queryroutes.

@C-Otto
Copy link
Contributor

C-Otto commented Jun 17, 2019

@joostjager Yes, I learned about the Router RPC calls that give the information I need. Attempt a payment, figure out why it fails, ignore the culprit node/edge, try again. A bit cumbersome, but it might work. See the discussion/progress in C-Otto/rebalance-lnd#51 and #3206 in case you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants