-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnct: commit sweep without nursery #3644
cnct: commit sweep without nursery #3644
Conversation
Note to self: reporting in PendingChannels (no more nursery report) |
496d99f
to
a9925dc
Compare
947635d
to
c3b6337
Compare
c3b6337
to
ff7f118
Compare
ff7f118
to
840f46f
Compare
To do: add commit sweep resolver unit test |
bed44a0
to
fad80f9
Compare
Unit test added, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome change, I can see this making it much simpler to add the new commitment ouputs later, and nice to have more of the sweeping being done by the sweeper 👍
fad80f9
to
3a69ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💹
01f1b14
to
5d330d6
Compare
Rebased on top of resolver constructors |
Unify resolver specific log statements. Leaves modification of the other resolvers for a later moment when it can be combined with a real change.
This commit prepares for the commit sweep resolver to report on its state.
5d330d6
to
41d84f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice commit structure 🤘
MaturityDelay: 3, | ||
} | ||
|
||
ctx := newCommitSweepResolverTestContext(t, &res) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the report at various times during the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check added
41d84f3
to
5e7af0f
Compare
The channel arbitrator no longer passes the direct commitment output to the nursery for incubation. Instead the resolver itself will await the csv lock if any. The reason to change this now is to prevent having to deal with the (legacy) nursery code for a planned anchor outputs related change to the commit sweep resolver (also csv lock to_remote). It is no problem if there are any lingering incubating outputs at the time of upgrade. This just means that the output will be offered twice to the sweeper and this doesn't hurt.
Now that the commit sweep resolver is no longer relying on the nursery, all code associated with commit sweeping can be removed.
5e7af0f
to
462d86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎩
This PR (finally) removes the dependency on the legacy utxo nursery from the commit sweep resolver.
The reason for doing this now, is that the new anchor output commitment format will also csv-lock the
to_remote
output. This requires changes and testing in this area and it seems like a good opportunity to clean up this technical debt.Subtask of #3587