Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoicesrpc+lnrpc: add msat fields to invoices #3729

Merged
merged 1 commit into from
Nov 18, 2019
Merged

invoicesrpc+lnrpc: add msat fields to invoices #3729

merged 1 commit into from
Nov 18, 2019

Conversation

joostjager
Copy link
Contributor

Fixes an oversight in the implementation of #3706

@joostjager joostjager added rpc Related to the RPC interface payments Related to invoices/payments v0.9.0 labels Nov 15, 2019
@joostjager joostjager added this to the 0.9.0 milestone Nov 15, 2019
@joostjager joostjager self-assigned this Nov 15, 2019
guggero
guggero approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@joostjager joostjager merged commit 88f037f into lightningnetwork:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpaulino wpaulino wpaulino approved these changes

@guggero guggero guggero approved these changes

Assignees

@joostjager joostjager

Labels
payments Related to invoices/payments rpc Related to the RPC interface
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joostjager @guggero @wpaulino