Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: random coin selection #5155

Merged
merged 1 commit into from
May 26, 2021
Merged

wallet: random coin selection #5155

merged 1 commit into from
May 26, 2021

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Mar 30, 2021 •
edited
Loading

Adds the option to use random coin selection for on-chain transfers.

Fixes #5110

Depends on btcsuite/btcwallet#740

@joostjager joostjager force-pushed the random-coins branch 2 times, most recently from 89ec633 to 67e9e18 Compare March 30, 2021 09:06
guggero
guggero approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature! Most of the heavy lifting is in btcsuite/btcwallet#740, so LGTM barring the dependencies and subsequent rebases 🎉

lnwallet/btcwallet/config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
chainreg/chainregistry.go Outdated Show resolved Hide resolved
@wpaulino wpaulino removed their request for review April 1, 2021 22:14
@joostjager joostjager force-pushed the random-coins branch 2 times, most recently from bc76d68 to c4b28e7 Compare April 6, 2021 07:10
@joostjager
Copy link
Contributor Author

Rebased after merge of #5047

wpaulino
wpaulino approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to land once the btcwallet changes are merged into upstream.

@joostjager
Copy link
Contributor Author

Is this PR close enough to acquire the 0.13 milestone tag?

@wpaulino wpaulino added this to the 0.13.0 milestone Apr 8, 2021
@wpaulino wpaulino added coin selection enhancement Improvements to existing features / behaviour wallet The wallet (lnwallet) which LND uses labels Apr 8, 2021
@wpaulino
Copy link
Contributor

wpaulino commented Apr 8, 2021

@joostjager added. Only thing left is for @Roasbeef to approve the btcwallet PR.

@joostjager
Copy link
Contributor Author

Rebased.

I hope you guys aren't going to let this miss the 0.13 train because of a single false-positive on the linter 🙏

@joostjager joostjager requested a review from Roasbeef May 17, 2021 07:46
@joostjager
Copy link
Contributor Author

Rebased after merge of btcsuite/btcwallet#740

@Roasbeef Roasbeef merged commit cede7a1 into lightningnetwork:master May 26, 2021
@Roasbeef Roasbeef mentioned this pull request Jun 1, 2021
Merged
@joostjager
Copy link
Contributor Author

This new function could use a few lines in the release notes

@guggero
Copy link
Collaborator

guggero commented Jun 3, 2021

Done. Though we usually do a sweep of all new PRs before the final release.

@joostjager
Copy link
Contributor Author

Thanks, I thought maybe it would have been forgotten as it doesn't happen so often that new functionality is added during the rc process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpaulino wpaulino wpaulino approved these changes

@guggero guggero guggero approved these changes

@Roasbeef Roasbeef Awaiting requested review from Roasbeef

Assignees
No one assigned
Labels
coin selection enhancement Improvements to existing features / behaviour wallet The wallet (lnwallet) which LND uses
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Improve coin selection
4 participants
@joostjager @wpaulino @guggero @Roasbeef