channeldb: node channels cache [poc] #5631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Aug 16, 2021
| @@ -14,6 +18,8 @@ func newChannelCache(n int) *channelCache { | |||
| return &channelCache{ | |||
| n: n, | |||
| channels: make(map[uint64]ChannelEdge), | |||
|
|
|||
| nodeChannels: make(map[route.Vertex][]ChannelEdge), | |||
There was a problem hiding this comment.
If the chan edge is a pointer, then it can just point into the entry in the channels map so things don't need to be allocated+stored twice for each channel.
There was a problem hiding this comment.
Yes, I that thought also crossed my mind. It does make things more complicated, so left it out for this PoC. For a first version in production, redundant storage could be an acceptable option. The cache size is limited anyway.
|
Superseded by #5642. Thanks for the PoC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough outline that shows how in-memory pathfinding could be implemented by extending the existing graph channel cache.