-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace all instances of 'ln' with 'lightning' in README.md #6
Conversation
|
||
``` | ||
go get -u -v github.com/lightningnetwork/lnd/... | ||
go get -u -v github.com/lightningnetwork/lightningd/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this without changing the name of the repo will cause future go get ...
calls to fail.
Hey @shea256, thanks for the PR! Changing the name of the project isn't as simple as changing a few lines in the README. As I pointed out in the comments above, changing the instructions for As this change may be a bit involved, I'm closing this PR for now. We'll handle the steps required to make a smooth switchover. |
@Roasbeef I realize that, I'm not a noob 😄 My point was to demonstrate how the language could be much better and how it would improve the branding / developer aesthetics, so I made some quick edits to the README.md file. I figured someone on the team would have to go through and make edits to variable names and such and multiple commits would be required for the update. Also I don't see why you'll need to create a new repo. Are you having people install directly from GitHub? I'm not quite familiar with go but surely it must have a package manager. And sounds good RE the switchover. |
It seems you should be able to do this without creating a new repo, but I could be mistaken. |
Yep, Go has a package manager. Go source code stored locally in a special "workspace". Within this workspace, packages are partitioned (under $GOPATH/src/) according to which version source control software each project uses. So if we change the name, then all A new repo would be required in order to avoid killing any active links to |
Actually, I'm wrong: Github does in fact redirect old links |
Yes of course, I knew that. I rename repos all the time. |
Add option to call AbandonChannel by validating the remote pubkey in non-development builds
This reverts commit 5cfa595. lnd 0.13.1 will also allow calling `abandonchannel` in non-debug builds (see lightningnetwork#5335)
…port-entrypoint accept 'signet' as LND_ENVIRONMENT variable
No description provided.