-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump btcec to v2, use integrated btcutil module #6285
Conversation
Seeing this test failure uniformly:
I think it might be due to: lightninglabs/neutrino#240 ? |
I think you may need to go into each sub-module and to |
553bce5
to
7246edf
Compare
Yes, you were right. It looks like that PR didn't account for reject messages correctly. I created a fix for it in lightninglabs/neutrino#247 and downgraded this PR to a version just before lightninglabs/neutrino#240 was merged. |
@guggero, remember to re-request review from reviewers when ready |
Needs a rebase! We'll eventually update to that neutrino version before we tag the next major release, so fine w/ going with the downgraded version here. |
6c5bc01
to
1309001
Compare
Rebased. |
1309001
to
df1f28b
Compare
Rebased again. @positiveblue PTAL. |
df1f28b
to
30cef00
Compare
Modules pops up with this warning:
I think it's missing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍭
Now that the PR uses the prior version of neutrino, we're no longer blocked on that fix, allowing us to move forward here on the taproot front!
Yeah, the intermediate commits (prefixed with |
30cef00
to
25f3326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @guggero thanks for splinting this in its own PR
The errors that Github actions show are only because some of the commits do not compile by itself but after squashing everything should pass (as it does in the last commit)
This commit was previously split into the following parts to ease review: - 2d746f68: replace imports - 4008f0fd: use ecdsa.Signature - 849e33d1: remove btcec.S256() - b8f6ebbd: use v2 library correctly - fa80bca9: bump go modules
Thank you for the review, @positiveblue! Going to squash the commits prefixed with Parts:
|
25f3326
to
e84c7fb
Compare
With the recent PR lightningnetwork#6285 merged that bumped the btcd dependency, we no longer need to bump the github.com/onsi/ginkgo package with a replace directive. Instead it was bumped indirectly by merging btcsuite/btcd#1780 which is included in the btcd version we reference.
Extracted out from #6263.
This PR switches
lnd
over to using the newbtcec/v2
andbtcutil
modules located in thebtcsuite/btcd
repo.All commits starting with
SQUASHME
will be squashed into a single commit before merging. They are only pushed separately for easier review.