Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcwallet: fix remote signing issues #7130

Merged
merged 6 commits into from
Nov 12, 2022
Merged

rpcwallet: fix remote signing issues #7130

merged 6 commits into from
Nov 12, 2022

Commits on Nov 11, 2022

  1. mod+keychain+lntest: bump btcd to version with tweak fix 

    This commit bumps to the latest version of btcd that fixes a key
mutation issue when signing for Taproot outputs.
    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    e3536dd View commit details
    Browse the repository at this point in the history

  2. mod: bump btcwallet to version with addr validation 

    This commit bumps the btcwallet dependency to the version that includes
the address validation that asserts we can sign for an address before we
use it.
    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    082d68d View commit details
    Browse the repository at this point in the history

  3. itest: add test coverage for Taproot tweak key mutation

    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b3f6fe3 View commit details
    Browse the repository at this point in the history

  4. rpcwallet: don't re-use sign desc in loop 

    This commit fixes an issue with signing for mixed inputs in a remote
signing setup where the re-use of the sign descriptor would lead to the
sign method not being reset correctly if a p2wkh input is following a
p2tr input.
    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    ed2e542 View commit details
    Browse the repository at this point in the history

  5. rpcwallet: pass prev output fetcher into ComputeInputScript 

    This commit fixes signing of Taproot inputs when some of the other
inputs of the transaction are not known to the wallet (such as a Pool
account for example).
If we want to sign for a Taproot (change) input when depositing into a
Pool account the wallet won't know the Pool account input. So we need to
make sure we pass it along inside the PrevOutputFetcher (which contains
the UTXO information extracted from the PSBT).
    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    5bd3e91 View commit details
    Browse the repository at this point in the history

  6. docs: add release notes for v0.15.5-beta

    @guggero
    guggero committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8b522aa View commit details
    Browse the repository at this point in the history