Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB #8183

Merged
merged 13 commits into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. [lncli] exportchanbackup single channel in hex

    It used to be base64, which is not compatible with verifychanbackup,
    expecting hex.
    starius committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a1aec88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e04aaa0 View commit details
    Browse the repository at this point in the history
  3. contractcourt: fix doc of commitSweepResolver

    It is used for sweeping time-locked outputs as well as non time-locked outputs.
    starius committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e7776a4 View commit details
    Browse the repository at this point in the history
  4. lnwallet: factor out func GetSignedCommitTx

    This pure function creates signed commit transaction, using various
    inputs passed as struct TaprootSignedCommitTxInputs and a signer.
    
    This is needed to be able to store the inputs without a signature
    in SCB and sign the transaction in chantools scbforceclose.
    
    See https://github.com/lightningnetwork/lnd/pull/8183/files#r1423959791
    starius committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    90c45dd View commit details
    Browse the repository at this point in the history
  5. chanbackup: add backup version for TapscriptRoot

    Previous to this change taproot assets channels and simple taproot channels were
    considered the same in the context of chanbackup package, since they stored the
    same data. In the following commits we are adding the data needed to produce a
    signed commitment transaction from a SCB file and in order to do that we need to
    add more fields and a custom channel gets one additional field (TapscriptRoot)
    compared to a simple taproot channel. So now we have to distinguish these kinds
    of channels in chanbackup package.
    
    See PR lightningnetwork#8183 for more details.
    starius committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f485e07 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. chanbackup: add Single.CloseTxInputs field

    The field is optional. It stores inputs needed to produce signed commit tx using
    chantools scbforceclose, which calls function GetSignedCommitTx. New backups
    have this field filled if commit tx is available (for all cases except when DLP
    is active). If a backup has this data, the field is filled from it, otherwise it
    is kept empty.
    
    Modified test function genRandomOpenChannelShell to cover new types of channels
    (simple taproot channel and custom channel) and to cover combinations of bits.
    Make sure that TapscriptRoot field is properly packed and unpacked.
    starius committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    df84148 View commit details
    Browse the repository at this point in the history
  2. chanbackup/pubsub: add method ManualUpdate

    This method inserts channel updates and waits for them to be processed. It will
    be used to update channel.backup upon LND shutdown.
    starius committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    fb397c1 View commit details
    Browse the repository at this point in the history
  3. server: produces a channel backup upon shutdown

    This is needed to keep channel.backup up-to-date if the node is stopped.
    starius committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    29946df View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ef85353 View commit details
    Browse the repository at this point in the history
  5. lntest: fix typo

    starius committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3de94c1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    25eecd7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eda06b1 View commit details
    Browse the repository at this point in the history
  8. docs/recovery: add Last resort manual force close

    Also updated release-notes.
    starius committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    65df996 View commit details
    Browse the repository at this point in the history