Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: use bitcoind v27.0 for CI #8573

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Mar 21, 2024

With this PR we want to assert compatibility with bitcoind v27.0 while it's still in RC.

Fixes #8571.
Depends on btcsuite/btcd#2142.

Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@guggero
Copy link
Collaborator Author

guggero commented Mar 21, 2024

Cool, looks like there are no additional incompatibilities with bitcoind v27.0, all unit and integration tests are green (except for those that currently always fail :/ ).

@saubyk saubyk added the back port candidate pr which should be back ported to last major release label Mar 21, 2024
@guggero guggero marked this pull request as ready for review April 18, 2024 15:44
@guggero guggero changed the title GitHub: use bitcoind v27.0rc1 for CI GitHub: use bitcoind v27.0 for CI Apr 18, 2024
Copy link
Collaborator

@Crypt-iQ Crypt-iQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Roasbeef Roasbeef merged commit d4c1937 into lightningnetwork:master Apr 18, 2024
24 of 27 checks passed
@guggero guggero deleted the bitcoind-27 branch April 19, 2024 05:32
@@ -21,7 +21,7 @@ defaults:
shell: bash

env:
BITCOIN_VERSION: "26"
BITCOIN_VERSION: "27"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back port candidate pr which should be back ported to last major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: sendcoins fails in bitcoind after v27
6 participants