Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zig 0.12 #203

Merged
merged 15 commits into from
Jun 18, 2024
Merged

Upgrade zig 0.12 #203

merged 15 commits into from
Jun 18, 2024

Conversation

krichprollsch
Copy link
Member

@krichprollsch krichprollsch commented Mar 29, 2024

⚠️ This PR is on hold, see https://github.com/lightpanda-io/project/issues/97 for details

0.12.0-dev.3439+31a7f22b8
0.12.0-dev.3518+d2be725e4
0.12.1

replaces on #202
depends on lightpanda-io/zig-js-runtime#216
depends on #242

@krichprollsch
Copy link
Member Author

krichprollsch commented Mar 29, 2024

I have multiple issues with this PR.

  • C import failed

zig build test and zig build shell fail due to two different C import failed error.

  • zig build test returns 'dom/dom.h' file not found
  • zig build shell returns 'linenoise.h' file not found

⚠️ but zig build get and zig build wpt work correctly. I don't understand where the difference is for dom.h 🤔

  • XMLHttpRequest cast error

Due to ziglang/zig#18955 I had to add a fixed buffer to XMLHttpRequest.
But in result, the issue lightpanda-io/zig-js-runtime#205 happens again....

@krichprollsch krichprollsch self-assigned this Mar 29, 2024
@krichprollsch krichprollsch changed the title Upgrade zig 0.12 [ON HOLD] Upgrade zig 0.12 Apr 3, 2024
@krichprollsch krichprollsch changed the title [ON HOLD] Upgrade zig 0.12 Upgrade zig 0.12 Jun 18, 2024
@krichprollsch krichprollsch marked this pull request as ready for review June 18, 2024 07:15
@krichprollsch krichprollsch merged commit f6e080b into main Jun 18, 2024
7 checks passed
@krichprollsch krichprollsch deleted the upgrade-zig branch June 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant