Remove special validation error handling #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 94.21% 94.85% +0.63%
==========================================
Files 66 66
Lines 3494 3458 -36
==========================================
- Hits 3292 3280 -12
+ Misses 155 133 -22
+ Partials 47 45 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mwear
approved these changes
Aug 24, 2022
|
This may have to wait until OTel-Go 1.11. Do not merge. |
|
This can merge after @kristinapathak's big PR. 😁 |
kristinapathak
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Lightstep had added custom handling for non-standard response headers; this is now standardized. Our special support can be removed
after open-telemetry/opentelemetry-go#3106 merges. EDIT: This is stalled until an OTel-Go metrics SDK includes a gRPC metrics exporter with PartialSuccess handling. Although 3106 merged, it did not release.Testing: Tested by applying the pending open-telemetry/opentelemetry-go#3106 and running
examples/metricswith a change ofOTEL_EXPORTER_OTLP_METRIC_TEMPORALITY_PREFERENCEto see validation errors.Documentation: Removed special documentation about a non-standard feature.