[RFC] cleanup bundle configuration

[havvg]

As mentioned in #293 the configuration of the bundle is currently a mess mixing actual configuration with implementations of some parts. We need to clean this up.

Global configuration settings to be removed:

• web_root (to be configured with the WebPathResolver service)
• data_root (to be configured with the FileSystemLoader service)
• cache_mkdir_mode (to be configured with the WebPathResolver service)
• cache_prefix (to be configured with the WebPathResolver service)
• cache_base_path (to be configured with the WebPathResolver service)
• formats (format conversion will be a separate filter to apply)

Filterset specific configuration to be removed:

• quality (compression will be a separate filter to apply)
• format (format conversion will be a separate filter to apply)
• path (will be moved into route configuration)

[makasim]

FYI: web_root, data_root, cache_prefix - was removed by #325, format was removed before.

Still open as not all settings were removed.

[wimvds]

How should we migrate projects that are currently using a global cache_prefix? I tried migrating them as specified in #325 using a resolver, but I keep getting an 'Unrecognized options "cache_prefix" under "liip_imagine"' error when clearing the cache...

ie. the following does not work :

liip_imagine:
    resolvers:
        web_path:
            web_path:
                web_root: ~
                cache_prefix: uploads/cache

    driver: imagick
    data_loader: filesystem
    data_root: %kernel.root_dir%/../web
    formats : ['jpg', 'jpeg','png', 'gif', 'bmp']
    filter_sets:
        optim:
            cache: web_path
            quality: 85
            format: jpg
            filters:
                strip: ~
        optimjpg:
            cache: web_path
            quality: 85
            format: jpg
            filters:
                strip: ~
        optimpng:
            cache: web_path
            quality: 85
            format: png
            filters:
                strip: ~

[makasim]

@wimvds please check you dont have liip_imagine.cache_prefix in any configuarion file. The config you posted looks fine. Thouse I am not sure it was not set set somewhere else. You know configs are merged before they validated.

[makasim]

@wimvds FYI format parameter is not taken into account any more. The cache image created in the same form the source image is.

[wimvds]

Ok, there was an unadapted config in one of the 3rd party bundles as well.

[makasim]

@wimvds is the issue solved? is there any other problems?

[wimvds]

The issue is resolved (apart from the missing format option that we currently actually use - to prevent users from adding BMP images on the web...). For the time being we'll just continue using v0.20.2.

[makasim]

formats and data_root removed in #371

[trsteel88]

format (format conversion will be a separate filter to apply)

I can't see this separate filter? Is this still a WIP?

[makasim]

@trsteel88 it is not implemented, and unfortunately do not see a solution here. There are big chances that this would not be included to 1.0

[trsteel88]

Wouldn't it be best to leave the format on the filters until that filter is done then?

[makasim]

maybe it would be good but it is already removed and there is no way to easily revert it (The remove was done as part of bigger PR).

Could be only re added again. I dont come up with a clean solution and I would not do hacky one too. I am going to release 1.0 without this feature. that's the plan

[makasim]

Some of the issues listed here where implemented in 1.0. The rest will go to 2.0.

[azine]

anyone still wanting to use the "format" option in the filter_sets => in v0.17.0 it is still present.