-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] cleanup bundle configuration #294
Comments
FYI: Still open as not all settings were removed. |
How should we migrate projects that are currently using a global cache_prefix? I tried migrating them as specified in #325 using a resolver, but I keep getting an 'Unrecognized options "cache_prefix" under "liip_imagine"' error when clearing the cache... ie. the following does not work :
|
@wimvds please check you dont have |
@wimvds FYI |
Ok, there was an unadapted config in one of the 3rd party bundles as well. |
@wimvds is the issue solved? is there any other problems? |
The issue is resolved (apart from the missing format option that we currently actually use - to prevent users from adding BMP images on the web...). For the time being we'll just continue using v0.20.2. |
|
I can't see this separate filter? Is this still a WIP? |
@trsteel88 it is not implemented, and unfortunately do not see a solution here. There are big chances that this would not be included to 1.0 |
Wouldn't it be best to leave the format on the filters until that filter is done then? |
maybe it would be good but it is already removed and there is no way to easily revert it (The remove was done as part of bigger PR). Could be only re added again. I dont come up with a clean solution and I would not do hacky one too. I am going to release 1.0 without this feature. that's the plan |
Some of the issues listed here where implemented in 1.0. The rest will go to 2.0. |
anyone still wanting to use the "format" option in the filter_sets => in v0.17.0 it is still present. |
As mentioned in #293 the configuration of the bundle is currently a mess mixing actual configuration with implementations of some parts. We need to clean this up.
Global configuration settings to be removed:
web_root
(to be configured with the WebPathResolver service)data_root
(to be configured with the FileSystemLoader service)cache_mkdir_mode
(to be configured with the WebPathResolver service)cache_prefix
(to be configured with the WebPathResolver service)cache_base_path
(to be configured with the WebPathResolver service)formats
(format conversion will be a separate filter to apply)Filterset specific configuration to be removed:
quality
(compression will be a separate filter to apply)format
(format conversion will be a separate filter to apply)path
(will be moved into route configuration)The text was updated successfully, but these errors were encountered: