Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][Configuration] Cleanup bundle configuration. #325

Merged
merged 1 commit into from
Mar 6, 2014

Conversation

makasim
Copy link
Collaborator

@makasim makasim commented Feb 9, 2014

This PR address #287 RFC and partly #294 RFC.

Currently I added a factory only for web path resolver. This is how you can configure it:

liip_imagine:
    resolvers:
       # default options
       web_path:
           web_path: ~ 

       # with custom options
       images_web_path:
           web_path:
               web_root: foo
               cache_prefix: images/cache

Later you can refer to them as before:

liip_imagine:
      filter_sets:
        thumbnail:
            cache: web_path
            filters:
                thumbnail: { size: [223, 223], mode: inset }

        images_thumbnail:
            cache: images_web_path
            filters:
                thumbnail: { size: [223, 223], mode: inset }

@havvg havvg added this to the v1.0.0 milestone Feb 10, 2014
@makasim
Copy link
Collaborator Author

makasim commented Feb 21, 2014

added factory for aws_s3 with ability to enable caching.

liip_imagine:
    resolvers:
       aws_s3:
          aws_s3:
              client_config:
                  key:    %amazon.s3_key%
                  secret: %amazon.s3_secret%
                  region: %amazon.s3_region%
              bucket:     %amazon.s3_cache_bucket%
              cache:      liip_doctrine_cache.ns.imagine_cache

@makasim
Copy link
Collaborator Author

makasim commented Feb 21, 2014

just added stream data loader factory

liip_imagine:
    loaders:
        stream_image:
            stream:
                wrapper: gaufrette://image/

@makasim
Copy link
Collaborator Author

makasim commented Feb 21, 2014

@havvg wdyt?

@makasim
Copy link
Collaborator Author

makasim commented Feb 24, 2014

@havvg added tests. Almost done here. Still have to add some tests and update the doc. Other factories will be added in separate PRs.

@makasim
Copy link
Collaborator Author

makasim commented Mar 3, 2014

@havvg ping

@makasim
Copy link
Collaborator Author

makasim commented Mar 5, 2014

added docs. I am going to merge this tomorrow.

makasim added a commit that referenced this pull request Mar 6, 2014
[1.0][Configuration] Cleanup bundle configuration.
@makasim makasim merged commit 7253587 into liip:develop Mar 6, 2014
@makasim makasim deleted the resolvers-factories branch March 6, 2014 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants