Update dependencies, including dev-develop for imagine #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Feb 10, 2022
| @@ -24,7 +24,7 @@ | |||
| "require": { | |||
| "php": "^7.4|^8.0", | |||
| "ext-mbstring": "*", | |||
| "imagine/imagine": "^1.2.4", | |||
| "imagine/imagine": "dev-develop", | |||
There was a problem hiding this comment.
i would prefer to only use stable versions of upstream dependencies.
but happy to raise the version to the latest released major version.
|
Makes sense. They've fixed the deprecation warnings in dev-develop, so
we'll just get them in our v3 until they've released, then we can make the
same adjustments.
I'll be happier when the newer versions are out and working in harmony, as
I'm a bit confused with how to get Symfony 5.4/6, Flysystem,
flysystem-bundle, and liip-imagine all working together with their latest
production releases. I used to use SymfonyCast All About Uploading, but it
has too many outdated dependencies.
Can you point me to a demo repo that includes those 4 components and
works? I think a lot of us have basic and similar needs -- let users
upload an image (to a local dir in dev, an s3 bucket in prod), then
dynamically show different sizes of it.
Thx.
…On Thu, Feb 10, 2022 at 2:38 AM David Buchmann ***@***.***> wrote:
***@***.**** commented on this pull request.
thanks!
i am -1 on using a develop version of imagine, the rest seems good to me.
allowing the new flysystem and log could maybe even be done in the 2.x
branch as well, i don't think there are changes for consumers, only for
implementers.
------------------------------
In composer.json
<#1458 (comment)>
:
> @@ -24,7 +24,7 @@
"require": {
"php": "^7.4|^8.0",
"ext-mbstring": "*",
- "imagine/imagine": "^1.2.4",
+ "imagine/imagine": "dev-develop",
i would prefer to only use stable versions of upstream dependencies.
but happy to raise the version to the latest released major version.
—
Reply to this email directly, view it on GitHub
<#1458 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQMELUVQGZWNJI3ELEDU2N2Q5ANCNFSM5N6C674A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
i am not aware of a current demo repository. the (released from the 2.x branch) LiipImagineBundle has tests running with symfony 6 though, so i would expect it to work with symfony 6. getting the imagine-bundle 3 released still has a bunch of tasks that need to be done, don't hold your breath for that to happen too soon ;-) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this bundle is a wrapper around php-imagine, and version 3 is our dev version, I've updated the require-dev components to allow the latest versions of everything. By using the dev-develop version of imagine, all the deprecation notices from that library disappeared.
Tests pass.
However, I don't know how stable dev-develop is. So should v3 of this bundle support dev-develop? Maybe someone from the imagine library can jump in.