-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controllerAs and bindToController to ngDialog #236
Comments
|
Going to do it in near future. |
Documentation about controllerAs - https://github.com/likeastore/ngDialog#controlleras-string |
@egor-smirnov Both of these imply that you're creating a new controller specifically for the modal. What if you just want to inherit the parent controller's scope using vm (not $scope) syntax? I've been trying to find a solution there but haven't yet. |
@alxvallejo it would be helpful if you could open another issue for the |
I think it is a good idea to add controllerAs and bindToController to allow us to follow the Angular Style Guide (https://github.com/johnpapa/angular-styleguide), that uses vm (ViewModel) instead of $scope
The text was updated successfully, but these errors were encountered: