Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controllerAs and bindToController to ngDialog #236

Closed
sibelius opened this issue May 28, 2015 · 5 comments
Closed

Add controllerAs and bindToController to ngDialog #236

sibelius opened this issue May 28, 2015 · 5 comments
Assignees

Comments

@sibelius
Copy link

I think it is a good idea to add controllerAs and bindToController to allow us to follow the Angular Style Guide (https://github.com/johnpapa/angular-styleguide), that uses vm (ViewModel) instead of $scope

@maxklenk
Copy link

maxklenk commented Jun 1, 2015

controllerAs is supported, even it is not documented.

@egor-smirnov
Copy link
Member

Going to do it in near future.

@egor-smirnov
Copy link
Member

Documentation about controllerAs - https://github.com/likeastore/ngDialog#controlleras-string
Documentation about bindToController - https://github.com/likeastore/ngDialog#directive

@alxvallejo
Copy link

@egor-smirnov Both of these imply that you're creating a new controller specifically for the modal. What if you just want to inherit the parent controller's scope using vm (not $scope) syntax? I've been trying to find a solution there but haven't yet.

@faceleg
Copy link
Contributor

faceleg commented Jan 4, 2016

@alxvallejo it would be helpful if you could open another issue for the bindToController feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants