controllerAs error

[djindjic]

I have some strange behaviour after setting up controllerAs syntax. Here is a console log:

So I have simple code to try this feature:

...
      ctrl.openDialog = function () {
          ngDialog.open({
            template:   'popupTmpl.html',
            controller: [function() {
              var vm = this;
              vm.name = 'child';
            }],
            controllerAs: 'ctrlChild'
          });
        };
...

maybe you @andrewogburn know what is a problem?

[egor-smirnov]

I guess I know what's the issue. That's maybe because of [] inside controller definition. Not able to check it right now.

@djindjic does it work for you in case of following code?

      ctrl.openDialog = function () {
          ngDialog.open({
            template:   'popupTmpl.html',
            controller: function() {
              var vm = this;
              vm.name = 'child';
            },
            controllerAs: 'ctrlChild'
          });
        };

This is not a solution as we should correctly handle extra dependencies injected into controller, but just wanted to clarify that issue is because of [].

[djindjic]

@egor-smirnov just tried, I've got same issue.

[egor-smirnov]

@djindjic could you please prepare plunker where I could play with what you have right now?

[djindjic]

Yes, give me just a little time 👍

[aoggz]

Thinking through how I implemented it, I think it only supports named
controllers. I don't think it will ever work with an inline controller
definition. I just got to my desk, so I'm looking into it now.

On Fri, Jun 19, 2015, 5:59 AM Aleksandar Djindjic [email protected]
wrote:

Yes, give me just a little time [image: 👍]

—
Reply to this email directly or view it on GitHub
#259 (comment)
.

[aoggz]

Just submitted #260 that should resolve this issue. I confirmed it is working with inline controller definition as well as named controllers in a local project I'm working on.

[egor-smirnov]

@andrewogburn thanks, will check it later.

[djindjic]

just to confirm that master works with inline controller. thanks guys!