Setting the width through a property js

[negherbon]

Sometimes is useful put specific width through js property because dont need put any css class every single time you need a specific width. I believe this can help us.

Readme:

#222

[faceleg]

I don't understand why you've put a reference to #222 here?

[faceleg]

Although I personally would prefer to use classes, as I tend to want more differences than just width, I can understand this might help some users.

Additional changes required for merge:

• Update readme
• Check if width is string, if it is use value without 'px', for people who may want to specify width in a different unit

[faceleg]

You can use https://docs.angularjs.org/api/ng/function/angular.isString for the string check

[negherbon]

@faceleg thanks for answer, i put #222 reference because has a talk about how to set width and height. But you are right i need create one issue for that, i will close this pull request and create one issue first.

Thanks :)

[faceleg]

No that's fine, keep this PR open, I was just confused about the reference is all :)

[negherbon]

@faceleg ok, i will make the adjustments :)

[negherbon]

@faceleg done o/

[faceleg]

If you provide a Number, 'px' will be appended. To use a custom metric, use a String, e.g. '40%'.

[faceleg]

Added some comments, overall looks GREAT!

[faceleg]

This line: https://github.com/negherbon/ngDialog/blob/width-property/js/ngDialog.js#L548 needs to be expanded into a multi-line conditional please, then I think you're done

[negherbon]

@faceleg refactoring done, thanks

[faceleg]

Thanks a lot, especially for your attention to detail and patience.

[negherbon]

@faceleg, thank you for helping me, it was my first contribution and i'm very happy. :)

[faceleg]

You did great!

Don't be afraid to argue your case if you disagree with a suggestion by a maintainer :)