Merge pull request #2743 from lima-vm/alert-autofix-42

Fix code scanning alert no. 42: Incorrect conversion between integer types
lima-vm · Oct 16, 2024 · 64c3c41 · 64c3c41
2 parents 1ef9c5d + 934f5ff
commit 64c3c41
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/guestagent/guestagent_linux.go b/pkg/guestagent/guestagent_linux.go
@@ -279,7 +279,7 @@ func (a *agent) LocalPorts(_ context.Context) ([]*api.IPPort, error) {
 				res = append(res,
 					&api.IPPort{
 						Ip:       ipt.IP.String(),
-						Port:     int32(ipt.Port),
+						Port:     int32(ipt.Port), // The port value is already ensured to be within int32 bounds in iptables.go
 						Protocol: "tcp",
 					})
 			}

diff --git a/pkg/guestagent/iptables/iptables.go b/pkg/guestagent/iptables/iptables.go
@@ -67,10 +67,11 @@ func parsePortsFromRules(rules []string) ([]Entry, error) {
 	for _, rule := range rules {
 		if found := findPortRegex.FindStringSubmatch(rule); found != nil {
 			if len(found) == 4 {
-				port, err := strconv.Atoi(found[3])
+				port64, err := strconv.ParseInt(found[3], 10, 32)
 				if err != nil {
 					return nil, err
 				}
+				port := int(port64)
 
 				istcp := found[2] == "tcp"