9p: change the default securityModel from mapped-xattr to none
#1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
commented
Oct 17, 2022
docs/mount.md
Outdated
| @@ -59,7 +59,8 @@ mounts: | |||
| - location: "~" | |||
| 9p: | |||
| # Supported security models are "passthrough", "mapped-xattr", "mapped-file" and "none". | |||
| # 🟢 Builtin default: "mapped-xattr" | |||
| # "mapped-xattr" and "mapped-file" are useful for persistent chown but incompatible with symlinks. | |||
| # 🟢 Builtin default: "none" (since Lima v0.12.1) | |||
There was a problem hiding this comment.
(Maybe this should be rather in v0.13.0)
There was a problem hiding this comment.
Yes, I feel that changing defaults merits at least a minor version bump.
There was a problem hiding this comment.
Changed to v0.13.0.
v0.12.1 will be cancelled.
AkihiroSuda
force-pushed
the
9p-symlink
branch
from
03120bd
to
7137da9
Compare
The `mapped-xattr` model is known to be incompatible with symlinks: https://gitlab.com/qemu-project/qemu/-/issues/173 The `none` model is obviously incompatible with chown, but this is fine, as the reverse-sshfs does not support chown either. See issue 971 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
9p-symlink
branch
from
7137da9
to
9884bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mapped-xattrmodel is known to be incompatible with symlinks: https://gitlab.com/qemu-project/qemu/-/issues/173The
nonemodel is obviously incompatible with chown, but this is fine, as the reverse-sshfs does not support chown either.See issue #971