Resolve /usr/local/bin symlinks in hacks/lima-and-qemu #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All dylib references in the binaries and libs are updated to use "@executable_path/.." to locate libs. In macOS Monterey (Public Beta) this is resolved not relative to the symlink, but relative to the symlink target. To create a distro that works on Catalina/Big Sur *and* Monterey, the symlinks in the bin directory are resolved before packaging. Symlinks still need to be stored for at least /usr/local/share/qemu so that qemu will still be able to find its data files. Signed-off-by: Jan Dubois <[email protected]>
AkihiroSuda
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dylib references in the binaries and libs are updated to use
@executable_path/..to locate libs. In macOS Monterey (Public Beta) this is resolved not relative to the symlink, but relative to the symlink target.To create a distro that works on Catalina/Big Sur and Monterey, the symlinks in the
bindirectory are resolved before packaging.Symlinks still need to be stored for at least /usr/local/share/qemu so that qemu will still be able to find its data files.
Ref rancher-sandbox/rancher-desktop#518