Support for configurable network address for user-v2 #1626

balajiv113 · 2023-06-13T05:50:07Z

Keep the PR as draft for the following to be resolved

Handle existing zone in dynamically addition of DNS records containers/gvisor-tap-vsock#236
gvproxy internal dns resolver needs to handle all query types containers/gvisor-tap-vsock#233

What's done
The user-v2 now honours gateway and netmask properties.

networks:
  user-v2:
    mode: user-v2
    gateway: 192.168.109.1
    netmask: 255.255.255.0

With the support of configurable subnet, we also required to provided support for dynamic DNS for user-v2

Changes to DNS resolving for usernet

Before
VM <-> gvisor-tap-vsock <-> hostagent dns resolver

Now
VM <-> gvisor-tap-vsock

No UDP or TCP forwarding will happen. So DNS lookup's will be faster now

How to enable new way of DNS resolver ?
Disabling the hostResolver will enable this new DNS for vz driver and for user-v2 network.

hostResolver:
  enabled: false

Need opinion on this, as we will still use hostResolver.hosts even after enabled is false.

Behaviour change

With user-v2 we will not set LIMA_CIDATA_SLIRP_IP_ADDRESS. As IP address are assigned dynamically
DNS record for instance is changed from lima-default to lima-default.internal

TODO

Fix tests with hardcoded IP

AkihiroSuda · 2023-06-13T06:24:22Z

examples/experimental/net-user-v2.yaml

@@ -6,6 +6,10 @@ images:
 - location: "https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-arm64.img"
  arch: "aarch64"

+hostResolver:
+  enabled: false


Could you add a comment line to explain this?

Done. But am still looking for a way to maintain the config more cleaner.

Using hostResolver.hosts without hostResolver.enabled doesn't look clean.

@AkihiroSuda - Is the current model looking good for you ??

The other approach i had in mind was to use our custom hostResolver only for qemu slirp network and in all other cases we will use gvisor-tap-vsock. If this enabled is false, we will simply use vm dns resolver

Note: In the second approach we will loose support for IPv6 resolution

@jandubois PTAL

The other approach i had in mind was to use our custom hostResolver only for qemu slirp network and in all other cases we will use gvisor-tap-vsock.

Will this work for VPN users?
If so, we can just ignore hostResolver for user-v2 mode.

Will this work for VPN users?

Yes yes, user-v2 will also work for VPN users as far as i checked

If so, we can just ignore hostResolver for user-v2 mode.

So basically whether hostResolver is present or not we will not consider it right ?

So basically whether hostResolver is present or not we will not consider it right ?

Right, assuming that nobody needs hostResolver.enabled = true for user-v2 mode

To fully understand,
hostResolver.hosts will still be used right ?? To set the custom host names.

With this option the goal is that we will remove support for enable / disable and handle internally for user-v2

To fully understand, hostResolver.hosts will still be used right ?? To set the custom host names.

Yes 👍

With this option the goal is that we will remove support for enable / disable and handle internally for user-v2

👍

Done the changes

AkihiroSuda · 2023-06-19T06:35:03Z

Is this still a draft?

balajiv113 · 2023-06-19T07:36:44Z

Is this still a draft?

Its good for review now. I was just waiting for the other issue to get closed. But we can proceed further.

pkg/networks/usernet/gvproxy.go

raja · 2023-07-06T11:34:05Z

Is this still a draft?

Its good for review now. I was just waiting for the other issue to get closed. But we can proceed further.

It appears that the referenced gvisor pr's have been merged. Is this good to review?

balajiv113 · 2023-07-06T12:43:29Z

@raja Yes its up for review.

I will address any new review comments and merge conflicts over next week.

AkihiroSuda · 2023-07-24T02:58:23Z

Needs rebase

balajiv113 · 2023-07-24T07:19:20Z

Needs rebase

Done :)

AkihiroSuda · 2023-07-27T02:47:27Z

CI is failing

AkihiroSuda · 2023-07-28T15:06:15Z

TEST| [INFO] Testing proxy settings are imported
TEST| [INFO] FTP_PROXY: expected=FTP_PROXY=http://192.168.5.2:2121 got=FTP_PROXY=http://192.168.104.2:2121
TEST| [ERROR] proxy environment variable not set to correct value

https://github.com/lima-vm/lima/pull/1626/checks?check_run_id=15421021585

balajiv113 · 2023-07-28T15:14:17Z

I have fixed this but for some reason its failing in systemd strict check. Will try to fix early next week

pkg/networks/usernet/dns.go

examples/experimental/net-user-v2.yaml

Signed-off-by: Balaji Vijayakumar <[email protected]>

AkihiroSuda

Thanks

AkihiroSuda · 2023-09-03T15:08:06Z

examples/experimental/net-user-v2.yaml

@@ -6,6 +6,9 @@ images:
 - location: "https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-arm64.img"
  arch: "aarch64"

+hostResolver:
+  hosts:
+    host.docker.internal: host.lima.internal


Not sure if this is necessary here

balajiv113 force-pushed the subnet-user-v2 branch from 97d34d8 to 765b1b8 Compare June 13, 2023 05:57

AkihiroSuda reviewed Jun 13, 2023

View reviewed changes

AkihiroSuda added this to the v0.17.0 milestone Jun 13, 2023

AkihiroSuda added the component/network/user-v2 label Jun 13, 2023

balajiv113 force-pushed the subnet-user-v2 branch 2 times, most recently from b345133 to 953dfa4 Compare June 15, 2023 13:34

balajiv113 marked this pull request as ready for review June 19, 2023 07:42

AkihiroSuda requested a review from jandubois June 19, 2023 07:48

balajiv113 force-pushed the subnet-user-v2 branch from 953dfa4 to ff25aa5 Compare June 19, 2023 07:51

balajiv113 commented Jun 19, 2023

View reviewed changes

pkg/networks/usernet/gvproxy.go Show resolved Hide resolved

balajiv113 force-pushed the subnet-user-v2 branch from ff25aa5 to af037ec Compare July 11, 2023 07:40

AkihiroSuda previously approved these changes Jul 19, 2023

View reviewed changes

AkihiroSuda mentioned this pull request Jul 24, 2023

v0.17 planning #1681

Closed

balajiv113 dismissed AkihiroSuda’s stale review via 1ad3ca4 July 24, 2023 07:19

balajiv113 force-pushed the subnet-user-v2 branch from af037ec to 1ad3ca4 Compare July 24, 2023 07:19

balajiv113 mentioned this pull request Jul 26, 2023

Support for flexible Slirp IP address #902

Closed

balajiv113 force-pushed the subnet-user-v2 branch from 1ad3ca4 to 287ef5c Compare July 28, 2023 07:36

AkihiroSuda modified the milestones: v0.17.0, v0.18.0 Jul 30, 2023

balajiv113 force-pushed the subnet-user-v2 branch 2 times, most recently from ea4353d to 7576107 Compare July 31, 2023 05:48

AkihiroSuda reviewed Jul 31, 2023

View reviewed changes

pkg/networks/usernet/dns.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed Jul 31, 2023

View reviewed changes

examples/experimental/net-user-v2.yaml Outdated Show resolved Hide resolved

balajiv113 force-pushed the subnet-user-v2 branch 2 times, most recently from 23d43a1 to 6e62020 Compare August 9, 2023 12:32

Support for configurable network address for user-v2

fd62a15

Signed-off-by: Balaji Vijayakumar <[email protected]>

balajiv113 force-pushed the subnet-user-v2 branch from 6e62020 to fd62a15 Compare August 10, 2023 06:07

AkihiroSuda modified the milestones: v0.17.1, v0.18.0, v0.17.2 Aug 11, 2023

AkihiroSuda approved these changes Sep 3, 2023

View reviewed changes

AkihiroSuda reviewed Sep 3, 2023

View reviewed changes

AkihiroSuda merged commit 336c669 into lima-vm:master Sep 3, 2023
21 checks passed

AkihiroSuda mentioned this pull request Sep 27, 2023

v0.18 planning #1784

Closed

balajiv113 deleted the subnet-user-v2 branch November 23, 2023 05:23

anuragagarwal561994 mentioned this pull request Dec 4, 2023

Host resolution issue with Vpn abiosoft/colima#917

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for configurable network address for user-v2 #1626

Support for configurable network address for user-v2 #1626

balajiv113 commented Jun 13, 2023 •

edited

Loading

AkihiroSuda Jun 13, 2023

balajiv113 Jun 15, 2023

balajiv113 Jun 19, 2023 •

edited

Loading

AkihiroSuda Jul 19, 2023

AkihiroSuda Jul 31, 2023

balajiv113 Jul 31, 2023

AkihiroSuda Jul 31, 2023 •

edited

Loading

balajiv113 Jul 31, 2023

AkihiroSuda Jul 31, 2023

balajiv113 Aug 9, 2023

AkihiroSuda commented Jun 19, 2023

balajiv113 commented Jun 19, 2023

raja commented Jul 6, 2023

balajiv113 commented Jul 6, 2023

AkihiroSuda commented Jul 24, 2023

balajiv113 commented Jul 24, 2023

AkihiroSuda commented Jul 27, 2023

AkihiroSuda commented Jul 28, 2023

balajiv113 commented Jul 28, 2023

AkihiroSuda left a comment

AkihiroSuda Sep 3, 2023

Support for configurable network address for user-v2 #1626

Support for configurable network address for user-v2 #1626

Conversation

balajiv113 commented Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balajiv113 Jun 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkihiroSuda Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkihiroSuda commented Jun 19, 2023

balajiv113 commented Jun 19, 2023

raja commented Jul 6, 2023

balajiv113 commented Jul 6, 2023

AkihiroSuda commented Jul 24, 2023

balajiv113 commented Jul 24, 2023

AkihiroSuda commented Jul 27, 2023

AkihiroSuda commented Jul 28, 2023

balajiv113 commented Jul 28, 2023

AkihiroSuda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balajiv113 commented Jun 13, 2023 •

edited

Loading

balajiv113 Jun 19, 2023 •

edited

Loading

AkihiroSuda Jul 31, 2023 •

edited

Loading