Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limayaml: support template expansion in .mounts[].location and .mounts[].mountPoint #2588

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

norio-nomura
Copy link
Contributor

This PR is based on #2587. I will mark it as ready for review once #2587 is merged.

@norio-nomura norio-nomura marked this pull request as ready for review September 4, 2024 05:51
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Sep 4, 2024
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 536f375 into lima-vm:master Sep 5, 2024
27 checks passed
@norio-nomura norio-nomura deleted the support-template-in-mounts branch September 5, 2024 04:45
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants