templates: remove vz, vmnet, etc. in favor of the limactl CLI args
#2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
added
component/network/vmnet
impact/changelog
component/qemu/9p
component/vz
area/cli
jandubois
reviewed
Oct 15, 2024
|
Sorry, I was confused by other stuff being merged to |
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
dev
branch
2 times, most recently
from
559edd0
to
d3e683d
Compare
|
Failure: See also ansible/ansible#80108 |
What should we do with this? |
No, it is not. If re-running the test gets rid of the error, then let's merge this. |
|
Green, but took 52 mins (usually 20 mins) |
- `experimental/vz`: Merged into the default template in Lima v1.0. See also <https://lima-vm.io/docs/config/vmtype/>. - `vmnet`: Removed in Lima v1.0. Use `limactl create --network=lima:shared template://default` instead. See also <https://lima-vm.io/docs/config/network/>. - `experimental/net-user-v2`: Removed in Lima v1.0. Use `limactl create --network=lima:user-v2 template://default` instead. See also <https://lima-vm.io/docs/config/network/>. - `experimental/9p`: Removed in Lima v1.0. Use `limactl create --vm-type=qemu --mount-type=9p template://default` instead. See also <https://lima-vm.io/docs/config/mount/>. - `experimental/virtiofs-linux`: Removed in Lima v1.0. Use `limactl create --mount-type=virtiofs template://default` instead. See also <https://lima-vm.io/docs/config/mount/>. Signed-off-by: Akihiro Suda <[email protected]>
|
Decoupled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental/vz: Merged into the default template in Lima v1.0. See also https://lima-vm.io/docs/config/vmtype/.vmnet: Removed in Lima v1.0. Uselimactl create --network=lima:shared template://defaultinstead. See also https://lima-vm.io/docs/config/network/.experimental/net-user-v2: Removed in Lima v1.0. Uselimactl create --network=lima:user-v2 template://defaultinstead. See also https://lima-vm.io/docs/config/network/.experimental/9p: Removed in Lima v1.0. Uselimactl create --vm-type=qemu --mount-type=9p template://defaultinstead. See also https://lima-vm.io/docs/config/mount/.experimental/virtiofs-linux: Removed in Lima v1.0. Uselimactl create --mount-type=virtiofs template://defaultinstead. See also https://lima-vm.io/docs/config/mount/.