Assign ssh.localPort automatically to an available port
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
auto-assign-ssh-localport
branch
3 times, most recently
from
e5da6ee
to
640be98
Compare
jandubois
reviewed
Oct 8, 2021
|
This PR picks an available TCP port for They used the same port for convenience (so the user doesn't have to configure both), but if we pick a random free one, then we probably should pick the udp port separately, to be sure it is available. |
|
The current implementation disables the hostdns lookup because If the port is only determined by the hostagent, then the cidata ISO creation must also be delegated to the hostagent, as it needs to include those port settings, so they are known during cloud-init processing. |
AkihiroSuda
force-pushed
the
auto-assign-ssh-localport
branch
from
640be98
to
43a0ec6
Compare
|
Fixed to pick up a free UDP DNS port in |
jandubois
reviewed
Oct 8, 2021
- The hostagent now speaks REST API over `ha.sock` to provide the port information. See `pkg/hostagent/api`. - For backward compatibility, the "default" instance uses port 60022 by default. Close issue 131 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
auto-assign-ssh-localport
branch
from
43a0ec6
to
544d15d
Compare
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
auto-assign-ssh-localport
branch
from
988f156
to
0675508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ha.sockto provide the port information. Seepkg/hostagent/api.Close #131